Is this good Code?

Firerobot1008 · October 25, 2018, 3:12pm

All of our motors work with it.

#include “robot-config.h”

int main()
{
while(true)
{

Backleftmotor.spin(vex::directionType::fwd, Controller1.Axis3.value()/2, vex::velocityUnits::pct); //Tank Control : Motor runs at half speed
Backrightmotor.spin(vex::directionType::fwd, Controller1.Axis2.value()/2, vex::velocityUnits::pct); //Tank Control : Motor runs at half speed

if(Controller1.ButtonX.pressing()) // ARM1 motor runs for half speed when B is pressed
{
Arm1.spin(vex::directionType::fwd, 75, vex::velocityUnits::pct); // 3/4th

}
else
{
Arm1.stop(vex::brakeType::hold);

}
if(Controller1.ButtonB.pressing()) // ARM1 motor runs when Button B is being pressed.
{
Arm2.spin(vex::directionType::fwd, 75, vex::velocityUnits::pct); // Motor run at 3/4th speed

}
else

{
Arm2.stop(vex::brakeType::hold); //holds the arm where it is stopped

}

if(Controller1.ButtonUp.pressing())//Claw motor should run if Button Up is being pressed
{
Claw1.spin(vex::directionType::fwd, 75,vex::velocityUnits::pct);//Motor will run at 3/4th speed
}
else
{
Claw1.stop(vex::brakeType::hold);//if the button is not being pressed.
}

if(Controller1.ButtonUp.pressing())//If that button is being pressed
{
    Claw2.spin(vex::directionType::fwd,75,vex::velocityUnits::pct);//the motor wil run at 3/th speed
}
else
{
    Claw2.stop(vex::brakeType::hold);//The motor will stop if it is not pressed. 
}

}
}

callen · October 25, 2018, 5:33pm

It would help a lot if you used the code tags when posting.

The big problems I see are the following:

Your code doesn’t match your comments, so I’m not sure it does what you want. Look at ARM1 v. ARM2 and ButtonX v. ButtonB.
You don’t have any ways to run most those motors in other directions. Is that really what you want, to only run each of those arm/claw motors only in a single direction ever?

John_TYler · October 26, 2018, 12:56pm

In addition to the monodirectional arm and claw motor problem identified by @callen, you are also setting both motors in two places. Even if one of them was able to send a reverse signal to those motors, they would fight for control as it would be setting one value then immediately overwriting it with another value. Instead of using two separate


if...else

structures for each motor you should be using a single


if...else if...else

for each. The first

if

checks the up condition, the


else if

checks the down condition, and the


else

case covers the stationary case.

Firerobot1008 · October 26, 2018, 4:41pm

IDK when we tested it the motors worked in both directions.

callen · October 27, 2018, 5:25am

Are you sure? The comments said this, but I never spotted an actual instance of it. That’s why I said the code doesn’t match the comments.

Really? Arm1, Arm2, Claw1, and Claw2 ran in both directions? With exactly this code? Not Backleftmotor and Backrightmotor, as those should run in both directions.

Firerobot1008 · October 27, 2018, 7:06am

Yeah they did. I will create the same code with the comments that you all gave me. Thanks so much.

callen · October 27, 2018, 3:25pm

Really??? What button did you press to make ArM1 move backward? What button did you press to move Arm2 backward?

Firerobot1008 · October 28, 2018, 5:59am

For arm 1 it was buttons y and b

I forgot what it was for arm 2

callen · October 28, 2018, 7:35am

Then what you were using is not the code you’ve shown us.

Firerobot1008 · October 28, 2018, 10:06am

#include “robot-config.h”

int main()
{
while(true)
{

Backleftmotor.spin(vex::directionType::fwd, Controller1.Axis3.value()/2, vex::velocityUnits::pct); //Tank Control : Motor runs at half speed
Backrightmotor.spin(vex::directionType::fwd, Controller1.Axis2.value()/2, vex::velocityUnits::pct); //Tank Control : Motor runs at half speed

if(Controller1.ButtonX.pressing()) // ARM1 motor runs for half speed when B is pressed
{
Arm1.spin(vex::directionType::fwd, 75, vex::velocityUnits::pct); // 3/4th

}
else
{
Arm1.stop(vex::brakeType::hold);

}
if(Controller1.ButtonB.pressing()) // ARM1 motor runs when Button B is being pressed.
{
Arm2.spin(vex::directionType::fwd, 75, vex::velocityUnits::pct); // Motor run at 3/4th speed

}
else

{
Arm2.stop(vex::brakeType::hold); //holds the arm where it is stopped

}

if(Controller1.ButtonUp.pressing())//Claw motor should run if Button Up is being pressed
{
Claw1.spin(vex::directionType::fwd, 75,vex::velocityUnits::pct);//Motor will run at 3/4th speed
}
else
{
Claw1.stop(vex::brakeType::hold);//if the button is not being pressed.
}

if(Controller1.ButtonUp.pressing())//If that button is being pressed
{
Claw2.spin(vex::directionType::fwd,75,vex::velocityUnits::pct);//the motor wil run at 3/th speed
}
else
{
Claw2.stop(vex::brakeType::hold);//The motor will stop if it is not pressed.
}

}
}

callen · October 28, 2018, 10:23am

Looks like you posted the same or very nearly the same code. As I said, what you’ve posted and what you’re describing are not the same code. Look at what you said for ArM1.

Look at what your code says for Arm1 and Arm2.

Arm1 is being controlled by only button X. Meanwhile, button B is actually controlling Arm2.

It makes it very hard for us to help you when you’re posting different code than what you’re describing the robot using.

Firerobot1008 · October 28, 2018, 1:16pm

Ohhhhh I understand now. Thankyou for the help. How would I make the Arm 1 motor run in both directions? Should I do the 75 and -75 thing?

Thankyou so much.

callen · October 28, 2018, 4:26pm

Typically something like this:

if(Controller1.ButtonX.pressing()) {
   Arm1.spin(vex::directionType::fwd, 75, vex::velocityUnits::pct);
   }
else if(Controller1.ButtonY.pressing()) {
   Arm1.spin(vex::directionType::rev, 75, vex::velocityUnits::pct);
   }
else {
   Arm1.stop(vex::brakeType::hold);
   }

Firerobot1008 · October 28, 2018, 4:43pm

Ok I understand. Thankyou so much.

Firerobot1008 · November 1, 2018, 8:17pm

So will this code be better? We added the fwd and rev

#include “robot-config.h”

int main()
{
while(true)
{

Backleftmotor.spin(vex::directionType::fwd, Controller1.Axis3.value()/2, vex::velocityUnits::pct); //Tank Control : Motor runs at half speed
Backrightmotor.spin(vex::directionType::fwd, Controller1.Axis2.value()/2, vex::velocityUnits::pct); //Tank Control : Motor runs at half speed

if(Controller1.ButtonX.pressing()) // ARM1 motor runs for half speed when B is pressed
{
Arm1.spin(vex::directionType::fwd, 75, vex::velocityUnits::pct); // 3/4th

}
if(Controller1.ButtonX.pressing()) {
Arm1.spin(vex::directionType::fwd, 75, vex::velocityUnits::pct);
}
else if(Controller1.ButtonY.pressing()) {
Arm1.spin(vex::directionType::rev, 75, vex::velocityUnits::pct);
}
else {
Arm1.stop(vex::brakeType::hold);
}

if(Controller1.ButtonUp.pressing())//Claw motor should run if Button Up is being pressed
{
Claw1.spin(vex::directionType::fwd, 75,vex::velocityUnits::pct);//Motor will run at 3/4th speed
}
else
{
Claw1.stop(vex::brakeType::hold);//if the button is not being pressed.
}

if(Controller1.ButtonUp.pressing())//If that button is being pressed
{
    Claw2.spin(vex::directionType::fwd,75,vex::velocityUnits::pct);//the motor wil run at 3/th speed
}
else
{
    Claw2.stop(vex::brakeType::hold);//The motor will stop if it is not pressed. 
}

}
}

callen · November 2, 2018, 2:06am

This part doesn’t help:

because you have duplicate code to start the next part. This next part is what you want:

Firerobot1008:

if(Controller1.ButtonX.pressing()) {
Arm1.spin(vex::directionType::fwd, 75, vex::velocityUnits::pct);
}
else if(Controller1.ButtonY.pressing()) {
Arm1.spin(vex::directionType::rev, 75, vex::velocityUnits::pct);
}
else {
Arm1.stop(vex::brakeType::hold);
}

I would note that you lost your Arm2 code.

system · January 3, 2020, 10:12pm