To get to your question, what is wrong with your code?
Well, let’s use some thinking. If you are not getting an error message from your code, that probably means that your syntax is fine, or close to fine. So we can probably determine that it probably isn’t a syntax problem.
Since you stated that the drivetrain is able to run, but not the intake, we can probably assume that the problem won’t be in the motor configuration since you configure both motors the same way.
Looking at your functions, since the setDrive function works, and it is more or less exactly the same to your setIntakes function, the problem probably isn’t in your void setIntakes.
Well then, looking at opcontrol, there are only three lines of code dealing with the intakes.
I would suggest you try @NagiRamen’s suggestion as well, though I don’t think that it will fix it based on this.
Unfortunately, this is somewhat vague. If you want more help, it would be helpful to have some more information. Consider these questions:
Is the rightIntake not working? Is the leftIntake not working? Are both not working? Do they move at all? Do the motors spin when not powered? Can the brain drive the motor from the devices screen?
Maybe don’t use the function you configured in the while command, and use the direct motor movements. Something similar happened in VexCode with your turn function, so I ended up using the normal command. I myself am new to PROS so I’m not sure if this will help, but it’s worth a shot, and could be the reason the intakes aren’t working.
While this is the case there are very specific use cases where you are going to be able to use the advantages that pros has to offer. I would suggest learning pros during the summer/early season instead of the late season. There are very few high school teams that use pros. Vexcode is very functional, has an easier graphics system, and will run almost anything because the V5 brain has more than enough processing power.
Change the buttons to your liking, of course. This way, if the positive intake button is pressed, the intake power will be set to 127 (127 * 1 [active digital button]). If the negative is pressed, the intake power will be set to -127 (127 * 0 [inactive positive digital button] - 127 * 1 [active negative digital button]). Hope this helps!