Problem with coding Macro

[CrazyBanana575]

So I have a simple macro and when I click the button that activates the macro nothing happens. Is there something wrong with my code.

And also I wanted to know if there is a way to make the macro so that when the button is clicked, the tilter goes up -.05 rotations and then depending on how long I hold the button the tray will move.

• the tray and lift are inverted so that’s why they have a negative sign there.

    void driverMacros() {
      Tilter.setVelocity(100, vex::velocityUnits::pct);
      Tilter.rotateFor(-0.5, vex::rotationUnits::rev);
      vex::task::sleep(250);
      Lift.setVelocity(100, vex::velocityUnits::pct);
      Lift.rotateFor(-0.78, vex::rotationUnits::rev);
    }
  

---

void usercontrol(void) {
  Controller1.ButtonX.pressed( driverMacros );
  // User control code here, inside the loop
// User control code here, inside the loop
while (1) {
}

[ean]

It seems like your doing this in a competition template, so you would have to put “Controller1.ButtonX.pressed( driverMacros );” inside the while loop.

[rpm]

Controller1.ButtonX.pressed( driverMacros ); should not be inside the while.
look here for general info on callbacks:

How do I use the controller button pressed command

yea, this is used when polling the button, it returns a boolean indicating if the button is currently pressed or not. Controller1.ButtonA.pressing() These are used when you want your code to be event based. Controller.ButtonA.pressed( callback_pressed ); Controller.ButtonA.released( callback_released ); A callback used an an event is running in its own thread, that means you can block using time consuming code or a while loop if you really want to, for example, this code using namespace…

and here for not in while loop:

Callbacks

This should be outside of the while loop. (that is, before the while loop at the top of main) The idea here is that you are registering a function (the callback) that will be executed when the event fires. Having those lines inside the while loop is registering the function multiple times ( we eventually run out of internal event resources ) This Controller1.ButtonX.pressed(x_pressed); means register the function x_pressed, call it every time the button X is pressed. we have “pressed” ev…

[JasonFPV]

I’m not sure if this is best practice, but I would have done:
(also make sure to put a sleep statement in your loops)

void driverMacros() {
    Tilter.setVelocity(100, vex::velocityUnits::pct);
    Tilter.rotateFor(-0.5, vex::rotationUnits::rev);
    vex::task::sleep(250);
    Lift.setVelocity(100, vex::velocityUnits::pct);
    Lift.rotateFor(-0.78, vex::rotationUnits::rev);
  }//close macro

void usercontrol(void) {
      while (1) {
        if (Controller1.ButtonX.pressing()) {
          driverMacros();
        }//close if
       wait(10, msec);
      }//close loop
    }//close usercontrol